PHP Classes

PSR and Github

Recommend this page to a friend!

      PHP OAuth Library  >  PHP OAuth Library package blog  >  How to Implement a PH...  >  All threads  >  PSR and Github  >  (Un) Subscribe thread alerts  
Subject:PSR and Github
Summary:Question about this subject
Messages:4
Author:Jorge Vargas
Date:2015-08-26 02:48:47
 

  1. PSR and Github   Reply   Report abuse  
Picture of Jorge Vargas Jorge Vargas - 2015-08-26 02:48:47
I was to to know if you have planned to go into Github and if you will use some coding standard like PSR-2 or other.

  2. Re: PSR and Github   Reply   Report abuse  
Picture of Manuel Lemos Manuel Lemos - 2015-08-26 18:31:55 - In reply to message 1 from Jorge Vargas
Well I have my development repository in my development machine but it does not use Git.

As for PSR-2 I think it is too demanding. I would have to change my usual programming style that I use for many, many years to adapt to PSR-2. That would make me much less productive.

Anyway, if you intend to contribute with improvements, you are welcome to submit them directly to me here.

  3. Re: PSR and Github   Reply   Report abuse  
Picture of Jorge Vargas Jorge Vargas - 2015-08-27 12:27:09 - In reply to message 2 from Manuel Lemos
It must be better to declare visibility for vars and functions, now both functions and vars are public.

Also, a getDebug function to get output without accessing variable or error log.

public function getDebug()
{
if ($this->debug)
return $this->debug_output;
return false;
}

Or something like this.

  4. Re: PSR and Github   Reply   Report abuse  
Picture of Manuel Lemos Manuel Lemos - 2015-08-27 17:51:31 - In reply to message 3 from Jorge Vargas
Yes, that can be done in the next release. Anyway, in general you should look at the documentation available in HTML. If a function or variable is not described there, it is not public.